Skip to content

Conversation

@budde25
Copy link
Contributor

@budde25 budde25 commented Jun 19, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Adds a null check before a String comparison on the equals method
  • Fixes bug where downloading the same deleted file would cause the app to crash on a NullPointerException

Fixes the following issue(s)

Testing apk

debug.zip

Agreement

@TobiGr TobiGr added bug Issue is related to a bug downloader Issue is related to the downloader labels Jun 21, 2020
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you did looks reasonable, sorry for not reaching out before. Thank you :-D

@Stypox Stypox merged commit 2215ce5 into TeamNewPipe:dev Sep 9, 2020
This was referenced Sep 27, 2020
@opusforlife2 opusforlife2 mentioned this pull request Apr 2, 2021
14 tasks
ShareASmile pushed a commit to ShareASmile/NewPipeZing that referenced this pull request Aug 16, 2021
…rash

Fixes crash when a file is deleted then redownloaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug downloader Issue is related to the downloader

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NoNonsense-File-Picker: Crash when a file is deleted and redownloaded

4 participants